Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change MultiIndex index function signature to include the pk #670

Closed
maurolacy opened this issue Feb 22, 2022 · 2 comments · Fixed by #781
Closed

Change MultiIndex index function signature to include the pk #670

maurolacy opened this issue Feb 22, 2022 · 2 comments · Fixed by #781
Assignees
@maurolacy
Labels
breaking Breaking changes breaking-api Breaks contract API in an non-backwards-compatible way storage plus

Comments

@maurolacy
Copy link
Contributor

maurolacy commented Feb 22, 2022 •
edited
Loading

It would be good that the MultiIndex index function signature, instead of being fn(&T) -> IK, was fn(&PK, &T) -> IK instead.

That way, the pk (or parts of it) can be used for indexing. And so the index keys don't have / need to come from the values alone.
@maurolacy maurolacy mentioned this issue Feb 22, 2022
Merged
@ueco-jb ueco-jb changed the title [cw-storage-plus] Change MultiIndex index function signature to include the pk Change MultiIndex index function signature to include the pk Feb 22, 2022
@maurolacy maurolacy self-assigned this Feb 22, 2022
@0xForerunner
Copy link

Any progress being made on this?

@maurolacy
Copy link
Contributor Author

Shouldn't be too hard to do this change. Delayed mostly because it's a breaking change. Will give it a try.

@maurolacy maurolacy added breaking Breaking changes breaking-api Breaks contract API in an non-backwards-compatible way labels Aug 16, 2022
@maurolacy maurolacy mentioned this issue Aug 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maurolacy maurolacy

Labels
breaking Breaking changes breaking-api Breaks contract API in an non-backwards-compatible way storage plus
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add primary key to MultiIndex index fn params CosmWasm/cw-plus
3 participants
@0xForerunner @maurolacy @ueco-jb