Replace previous iter implementation on key type in Map

CosmWasm · Nov 15, 2021 · f0cfa5c · f0cfa5c
1 parent 38c6a58
commit f0cfa5c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/packages/storage-plus/src/helpers.rs b/packages/storage-plus/src/helpers.rs
@@ -22,15 +22,15 @@ pub(crate) fn may_deserialize<T: DeserializeOwned>(
     value: &Option<Vec<u8>>,
 ) -> StdResult<Option<T>> {
     match value {
-        Some(vec) => Ok(Some(from_slice(&vec)?)),
+        Some(vec) => Ok(Some(from_slice(vec)?)),
         None => Ok(None),
     }
 }
 
 /// must_deserialize parses json bytes from storage (Option), returning NotFound error if no data present
 pub(crate) fn must_deserialize<T: DeserializeOwned>(value: &Option<Vec<u8>>) -> StdResult<T> {
     match value {
-        Some(vec) => from_slice(&vec),
+        Some(vec) => from_slice(vec),
         None => Err(StdError::not_found(type_name::<T>())),
     }
 }

diff --git a/packages/storage-plus/src/keys.rs b/packages/storage-plus/src/keys.rs
@@ -202,7 +202,7 @@ impl<'a> PrimaryKey<'a> for Vec<u8> {
     type SuperSuffix = Self;
 
     fn key(&self) -> Vec<Key> {
-        vec![Key::Ref(&self)]
+        vec![Key::Ref(self)]
     }
 }
 
@@ -572,6 +572,7 @@ mod test {
     #[test]
     fn proper_prefixes() {
         let simple: &str = "hello";
+        assert_eq!(simple.prefix().len(), 1);
         assert_eq!(simple.prefix()[0].as_ref(), b"hello");
 
         let pair: (U32Key, &[u8]) = (12345.into(), b"random");

diff --git a/packages/storage-plus/src/map.rs b/packages/storage-plus/src/map.rs
@@ -9,7 +9,7 @@ use crate::helpers::query_raw;
 use crate::iter_helpers::{deserialize_kv, deserialize_v};
 #[cfg(feature = "iterator")]
 use crate::keys::Prefixer;
-use crate::keys::PrimaryKey;
+use crate::keys::{Key, PrimaryKey};
 use crate::path::Path;
 #[cfg(feature = "iterator")]
 use crate::prefix::{namespaced_prefix_range, Bound, Prefix, PrefixBound};
@@ -45,11 +45,7 @@ where
     pub fn key(&self, k: K) -> Path<T> {
         Path::new(
             self.namespace,
-            &k.key()
-                .iter()
-                .map(|e| e.as_ref())
-                .collect::<Vec<_>>()
-                .as_slice(),
+            &k.key().iter().map(Key::as_ref).collect::<Vec<_>>(),
         )
     }