Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memo support #1757

Closed
wants to merge 2 commits into from
Closed

memo support #1757

wants to merge 2 commits into from

Conversation

dzmitry-lahoda
Copy link
Contributor

No description provided.

@dzmitry-lahoda
Copy link
Contributor Author

before i will waste time fixing ci, are we ok with this change overall?

@webmaster128
Copy link
Member

This change is breaking and cannot be merged until we start a 2.0 branch. It is tracked in #1477.

Regarding the diff: I think it should be a non-optional memo: String. The type is string in protobuf and in Go/protobuf there is no difference between unser and empty string. So better only have one case in CosmWasm too.

@webmaster128
Copy link
Member

Thank you for this contribution. As discussed in other places this goes in cosmwasm-std 2.0. We have it covered by #1757, which is slightly different (especially Binary -> String) but this was inspired by your PR. Closing this now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzmitry-lahoda @webmaster128