Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsibility to start and end game #16

Open
JamesZhang2 opened this issue Oct 20, 2022 · 2 comments
Open

Responsibility to start and end game #16

JamesZhang2 opened this issue Oct 20, 2022 · 2 comments
Assignees

Comments

@JamesZhang2
Copy link
Contributor

I think it is more reasonable for the game engine to start and end the game, rather than having an agent send requests for starting and ending the game. Once 4 or 5 players are added, we could start the game; once a certain number of rounds is reached (or if someone runs out of money), we could end the game.

Also, it would be nice if the number of seconds of a round is customizable (i.e. set as a constant in the constants.py file). This will facilitate debugging.

@ili23
Copy link
Member

ili23 commented Oct 20, 2022

I agree with the second part about the time being customizable and we can look into implementing it soon.

I feel like the game should not automatically start or end since we are also building the backend out for live players and we want the players themselves to have control over starting and ending the game. However, I would like to hear your thoughts on this so let us know your reasoning for having the engine start the game once those conditions are met.

@JamesZhang2
Copy link
Contributor Author

JamesZhang2 commented Oct 20, 2022

I agree. Should we then have a request signaling that an agent is ready? Also, Figgie can only be played with 4 to 5 players, so should we start the game once we have 4 or 5 players and everyone is ready? I don't think the agents should be responsible for sending the "start game" request. They just need to send the "ready" request and the backend will decide to start the game when everyone is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants