-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack overflow when using custom playIcon
#740
Comments
Until the bug is fixed, you can customize the icon by redefining the styles. |
Hopefully sorted in |
Hey @seaneking @cookpete , |
albanqoku
added a commit
to albanqoku/react-player
that referenced
this issue
Feb 24, 2021
Webmaster1116
added a commit
to Webmaster1116/video-player
that referenced
this issue
May 20, 2021
webmiraclepro
added a commit
to webmiraclepro/video-player
that referenced
this issue
Sep 9, 2022
philip-luther
added a commit
to philip-luther/react-player
that referenced
this issue
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current Behavior
When using a custom play icon with the new
playIcon
prop, clicking the icon throws an stack overflow error with recursive calls toisEqual(object)
here https://github.com/CookPete/react-player/blob/master/src/utils.js#L165 in latest Chrome.Expected Behavior
Clicking the custom play icon should have the same behavior as the default play icon, and not blow up my app
Steps to Reproduce
The text was updated successfully, but these errors were encountered: