-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When minified, only one player component is mounted #17
Comments
Thanks for this @Fauntleroy! I'll add a quick commit and publish a patched version now. |
Fixed in v0.3.1 |
david-hub024
pushed a commit
to david-hub024/React_VideoPlayer
that referenced
this issue
Dec 23, 2018
david-hub024
pushed a commit
to david-hub024/React_VideoPlayer
that referenced
this issue
May 23, 2020
albanqoku
added a commit
to albanqoku/react-player
that referenced
this issue
Feb 24, 2021
Webmaster1116
added a commit
to Webmaster1116/video-player
that referenced
this issue
May 20, 2021
webmiraclepro
added a commit
to webmiraclepro/video-player
that referenced
this issue
Sep 9, 2022
philip-luther
added a commit
to philip-luther/react-player
that referenced
this issue
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm having a bit of an odd issue here:
When I use
react-player
in my project, then minify the project bundle, only one of the players will mount (the YouTube player). I have a hunch thatdisplayName
is somehow involved (since allreact-player
components are shown ast
in the React DevTools).#### Steps to replicate - Create a project that uses browserify - Use `react-player` in that project - Browserify your code - Minify your code - When the player is mounted, you should only see one player type mounted inside of it #### Ideas - Try minifying `react-player` in the test page and see if we can replicate the issue there - Try manually setting `displayName` for every component
The text was updated successfully, but these errors were encountered: