Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for issue #49 #50

Closed
wants to merge 1 commit into from
Closed

PR for issue #49 #50

wants to merge 1 commit into from

Conversation

KaiSchwarz-cnic
Copy link

@KaiSchwarz-cnic KaiSchwarz-cnic commented Jul 3, 2018

a note concerning the use of new URL and url.parse:
https://stackoverflow.com/questions/46416439/unable-to-import-url-class-in-nodejs-typescript-app

Thus I am not sure if you're completely ok with this PR.

I also have not tried out if compiling a template by url works, I assume it does.

@KaiSchwarz-cnic
Copy link
Author

Hey @cookpete

is there an update on this PR? : )
Don't worry, I don't want to pressure you - just want to ask if there's a timeline for this or if you do not plan to merge / to add that feature. Just some information so that we know how to proceed internally.

TIA!

@cookpete
Copy link
Owner

Hey Kai, I must admit I completely forgot about this.. sorry! I think the idea is good but I think we should separate the logic for fetching a template from a URL, so as to not affect the existing code too much (for a feature that won't be used very often) and also to stay working on all Node 6 versions (apparently the URL constructor was only added in 6.13.0).

@cookpete cookpete closed this in b3a21db Jul 23, 2018
@cookpete
Copy link
Owner

cookpete commented Jul 23, 2018

You can see my attempt to add support for this in b3a21db, published in 1.8.0. Let me know if it does the job.

@KaiSchwarz-cnic
Copy link
Author

Thanks for pointing on that, but 1.7.2 is the most current version available on npm :)

@cookpete
Copy link
Owner

Should be up now 👍

@KaiSchwarz-cnic
Copy link
Author

working ty! that was the reason why it did not work before. I exactly tried argument template with url in that way, but in version 1.7.2 :)

b6pzeusbc54tvhw5jgpyw8pwz2x6gs pushed a commit to b6pzeusbc54tvhw5jgpyw8pwz2x6gs/auto-changelog that referenced this pull request Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants