Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom version tag prefixes for multi-package repositories #22

Closed
jeffkpayne opened this issue Jan 2, 2018 · 9 comments
Closed

Comments

@jeffkpayne
Copy link

Again, let me say how much I love this tool. We've been using it for about a month and your responsiveness has been awesome.

One recent thing we've come up against is the inability to easily use it on git repos that contain more than one package because of version tag collisions. A common practice when housing more that one package in a single repo is to use a tag pattern like <package>-<version> so that multiple packages can be versioned individually. The problem arrises with auto-changelog when the changelog file is generated, because of the semver.valid() test at https://github.com/CookPete/auto-changelog/blob/b6edd204a38e7eceaaa0c9e71c7e5a9e45cecdf9/src/releases.js#L11.

Have you come up against this or is this use case just not supported?

@flochtililoch
Copy link

@jeffkpayne I needed that support too so I quickly hacked it together - not the cleanest by any mean and haven't took the time to add test coverage so I won't open a PR for now.
@cookpete Let me know if you want me to open a PR for this change - and thank you for providing this module!

@flochtililoch
Copy link

One caveat of my solution is it doesn’t filter out commits from unrelated packages, so this might still need a little more work

@jeffkpayne
Copy link
Author

Yeah, to be honest, I hadn't even thought about that problem. Could be solved with post-processing the changelog file or maybe even with some conditionals in the handlebars template, which would, for instance, exclude commit/merge/fix messages without the target package "label"...

@cookpete
Copy link
Owner

cookpete commented Jan 8, 2018

This is an interesting problem. What would the intended solution be here? If we support a prefix option, it would limit the changelog to just one package, so would you run auto-changelog twice for each?

auto-changelog --output changelog-alpha.md --tag-prefix package-alpha-
auto-changelog --output changelog-beta.md --tag-prefix package-beta-

As @flochtililoch mentions, this also suggests a need for an --ignore-commit-pattern option, which would be good to have either way.

@jeffkpayne
Copy link
Author

  1. Well, the <package> part of the tag could just be based on the package name in package.json, so, yes, you would run the auto-changelog command for each package that was being released. Not quite sure what you mean by running "auto-changelog twice for each..."
  2. Right, there would have to be something in the commit message that could be used as a switch to include/exclude it from the changelog for that package.

@cookpete
Copy link
Owner

cookpete commented Jan 10, 2018

Well, the part of the tag could just be based on the package name in package.json

I think it's better to remain flexible and allow users to pass in any prefix they might be using.

Not quite sure what you mean by running "auto-changelog twice for each..."

Sorry, badly worded. I meant run it twice (or more), once for each package you are generating a log for.

Right, there would have to be something in the commit message that could be used as a switch to include/exclude it from the changelog for that package.

Yeah it would depend on a consistent commit message pattern for your use case, but I think it's a helpful feature anyway for reducing noise in logs.

@jeffkpayne
Copy link
Author

Sounds awesome. Just curious, do you know of a good primer for getting set up locally for node.js development? I'd love to tackle this kind of thing myself, but am a little confused about how to build/test changes locally...

@cookpete
Copy link
Owner

It should be as simple as installing node.js and then:

# clone and cd into root dir
git clone https://github.com/CookPete/auto-changelog.git # or your own fork
cd auto-changelog

# install dependencies
npm install 

# run tests locally
npm test 

# compile src files to lib
npm run build

# run compiled version locally
node lib/index.js --output custom-output.md 

Just a heads up – I have already added --tag-prefix and --ignore-commit-pattern options, but have not yet pushed/published them. Feel free to play around with things locally though.

@cookpete
Copy link
Owner

--tag-prefix and --ignore-commit-pattern added in 1.4.0

b6pzeusbc54tvhw5jgpyw8pwz2x6gs pushed a commit to b6pzeusbc54tvhw5jgpyw8pwz2x6gs/auto-changelog that referenced this issue Sep 19, 2018
Feels cleaner to use http://shields.io for everything

Remove todo list from readme

Should ideally be issues on github

Add option for specifying output file

Fixes cookpete#1 and cleans stuff up a bit

Add newline at end of generated logs

Add support for --package

Uses the version from package.json as the latest version, which lets you do cool stuff like generating a changelog as part of a version bump commit, see README.md for more

Generate changelog on version

0.1.0

Fix --package bug

Prefixing inside generateLog caused the param to always be truthy, which messed up parseReleases

Explicitly render links for PRs and issues

GitHub doesn't automatically parse them in markdown files like it does for PRs, issues and comments

0.1.1

Add FAQ to readme

Rearrange usage docs

Add support for specifying templates

Also add a simple compact template

Start using compact changelog

It just seems.. nicer

Lint and test before versioning

0.2.0

Replace toLocaleString usage with months array

Not supported in node 0.10

0.2.1

Update templating logic

Cleans up how logs are rendered
Keeps things DRY between the two templates

More sensible formatDate

There was no point making it an external function in Compact when it's already a class method in Default

Add a commit-only release to test data

Beefs up the rendering tests a bit, covering more bases

0.2.2

Add support for minimumChangeCount in templates

Backfill release notes with commits up to the given threshold
Prevents releases that list only a single merge or fix, even if larger changes may have been commited as well

Add semicolons after class properties

To support babel 6.4.x

Remove unique issue filter

Broken since storing several issues per commit, so now causes more problems than it solves

Case insensitive issue URL parsing

0.3.0

Bump packages

Lint fixes

Correct find polyfill usage

More robust log separators

Improve cmd util

Improve origin URL parsing

Fixes cookpete#2 and fixes cookpete#5

Improve error handling

Add extra commits test

Use template literal for success string

Bump packages

Remove semicolons

No longer required with latest version of standard

0.3.1

Prevent duplicate commits being listed

Fixes cookpete#3

0.3.2

Lint fix

Bump packages

And add yarn lockfile
Fixes cookpete#7

Use babel-preset-env

0.3.3

Update travis to use later versions of node

Add code coverage

Remove parseInt radix

No longer required by standard

Fix travis node versions

Tweak default template date format

Disable codecov comments and build status

Add yarn cache to travis config

Generate coverage reports when testing locally

Remove need for array.find polyfill

Use async/await instead of promises

Tweak version script

0.3.4

Add babel-polyfill

Fixes cookpete#8
Requires babel-polyfill to be imported before the main file due to aggressing async function hoisting
babel/babel#6206

0.3.5

Use origin hostname instead of host

`host` includes the port number, which can break links
Hopefully fixes cookpete#9

Correct bitbucket compare URLs

0.3.6

Improved issue matching

Now supports any generic issue URL that contains `/issues/{number}`

Update dependencies to enable Greenkeeper 🌴 (cookpete#10)

* chore(package): update dependencies

* docs(readme): add Greenkeeper badge

Tweak readme badges

Remove dependency status badges

With greenkeeper enabled, they will pretty much always been up to date, right?

Refactor codebase

Add greenkeeper-lockfile support

1.0.0

Update readme

Filter out commits with the same message as an existing merge

1.0.1

Tweak package read logic

Fall back to https origin protocol

1.0.2

Tweak version script

Fix pull request URL

Bump packages

Limit origin protocol to http or https

Fix version script

babel-node was erroring when using -p

1.0.3

Tidy options logic

Keep coverage files inside test directory

Tweak origin properties

Add origin tests

Add script to generate test data

Update clean script

Refactor run logic

Add run tests

Move test origins to separate file

Exclude index.js from test coverage

Remove unused options param from cmd util

Tweak removeIndentation util

Add util tests

Fix multiple issue URL parsing

Support modifying commit limit with --commit-limit (cookpete#12)

* Support modifying commit limit with --commit-limit

* Tidy up commit limit logic

1.1.0

Update readme

Parse squash merge commits with no commit message

Update formatting of shameless plug in templates

Add npm script for generating test data

Parse squash commits with broken messages

Slightly larger heading for major releases

Add major release to test data

Add issue-url option to override issue URLs

Fixes cookpete#13

Add basic requirements to readme

1.2.0

Use commander instance

Increase test coverage

Add commit with matching PR message to test data

To ensure the commit is filtered out of changelogs

Add commit to test data to trigger sorting

Add tests

Remove support for broken message squash merge

Filter out merge commits

Closes cookpete#14

Parse commits that close pull requests

1.2.1

Fix error when using --unreleased flag

Fixes cookpete#16

1.2.2

Update fs-extra to the latest version 🚀 (cookpete#19)

* fix(package): update fs-extra to version 5.0.0

* chore(package): update lockfile

https://npm.im/greenkeeper-lockfile

Add --latest-version option

Closes cookpete#17

Update tests

Add --issue-pattern option

Closes cookpete#18

Override package options with command line options

Add --starting-commit option

Closes cookpete#21

1.3.0

Add merge commit to test data

Add package version test

Add --tag-prefix option

Closes cookpete#22

Add --ignore-commit-pattern option

Update niceDate tests to avoid timezone issues

Fixes cookpete#24
Closes cookpete#25
The formatting is the main thing we want to test, not the exact date being correct (we can assume the JS engine will not fail us).

Add support for generating logs without a git remote

Fixes cookpete#23

Change use of "origin" to "remote"

"origin" doesn't really make sense, as it is just the name of the default remote for most repos
"remote" is more correct in the context of the code

Fix tag prefix logic

Update mocha to the latest version 🚀 (cookpete#26)

* chore(package): update mocha to version 5.0.0

* chore(package): update lockfile

https://npm.im/greenkeeper-lockfile

1.4.0

Support commits with no message

Fixes cookpete#27

1.4.1

Update standard to the latest version 🚀 (cookpete#29)

* chore(package): update standard to version 11.0.0

* chore(package): update lockfile

https://npm.im/greenkeeper-lockfile

* Lint fix

Support for gitlab subgroups and self-hosted instances (cookpete#28)

1.4.2

Add tag prefix to compare URLs

Fixes cookpete#30

1.4.3

Do not show date for unreleased section

Fixes cookpete#31

Fix unreleased compare URL

1.4.4

Correctly prefix package version

Fixes cookpete#33

1.4.5

Added support for old git versions (cookpete#35)

1.4.6

Use UTC dates by default

Fixes cookpete#37

Add commit-list template helper

Fixes cookpete#36 and fixes cookpete#39

Remove unused imports from template tests

Feat: match template helper (cookpete#40)

Move helper tests to separate files

1.5.0

Add --include-branch option

Fixes cookpete#38

Fix duplicate test data commit hashes

Add --breaking-pattern option

Fixes cookpete#41

1.6.0

Add replaceText package option

1.7.0

Fix releases sorting when unreleased enabled (cookpete#45)

Update git log format to support earlier git versions

Fixes cookpete#43

Use async fs utils instead of fs-extra

Closes cookpete#42
Also, tidies up imports

1.7.1

Remove node 4 and 5 from travis builds

Enable partial line coverage with codecov

Also move coverage into root

Use %B for supported git versions

The fallback was causing problems for commit messages with single newlines

Add engines to package.json

Add markdown linting

Fixes cookpete#47

Fix changelog spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants