Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add db_index option to Redis cache configuration #380

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

DeanNeaht
Copy link
Contributor

Description

This PR introduces the db_index option in the Redis cache configuration for chproxy. The feature allows specifying a particular Redis database index for caching

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • Linter passes correctly
  • Add tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Does this introduce a breaking change?

  • Yes
  • No

@mga-chka
Copy link
Collaborator

FYI all the maintainers are off, we'll review the PR in January

Copy link
Collaborator

@mga-chka mga-chka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment.
Once its done I'll merge you PR and it will be part of the next release (that should happen in 1-2 weeks, the time to have all the current PR approved & merged)

config/README.md Outdated
@@ -111,6 +111,7 @@ redis:
- <string> # example "localhost:6379"
username: <string>
password: <string>
db_index: <int> | default = 0 [optional]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, can you add a comment that it only works for non clustered redis? Even its "obivous" for a redis poweruser, it might prevent some false issues on the chproxy repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@mga-chka mga-chka merged commit 50817d1 into ContentSquare:master Jan 3, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants