-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refresh_token_expires_at and sharing_expires_at claims listed as MUST be supported #543
Comments
Thanks @anzbankau It appears that the MUST statements you've referred to should have also been removed when the following details in the Token Expiry section were removed, as the obligation had passed by version 1.25.0 (8 July 2023) -
|
This proposed change could result in the following -
with -
|
Attendees of the 6 March Maintenance Iteration call discussed the implications of removing outdated statements related to the For context; statements noting that '[From September 16th 2022] Data Holders MAY retire "sharing_expires_at" and "refresh_token_expires_at" claims' were included in the standards from version 1.15.0 (23/12/2021) until version 1.24.0 (07/05/2023), however there are still related statements in the current Standards declaring that they 'MUST be supported'. There was feedback that calling the introspection endpoint after each token collection call would increase load on Data Holders. One attendee noted that while The DSB does not consider that such a requirement is necessary to be added to the Standards, and it could be in opposition to Decision 209 - Transition to FAPI 1.0 Advanced Profile (16/12/2021) which incorporated feedback to the original design questions:
As the proposed change would ensure the Standards are aligned to that decision, and it does not preclude the use of the previous fields where supported, it remains the preferred approach and is considered to be a non-breaking change. Any further comments are welcome. |
This issue was discussed in the 20th March Maintenance Iteration call.
|
This change has been staged for review here: ConsumerDataStandardsAustralia/standards-staging@release/1.30.0...maintenance/543 |
As discussed:
|
Thanks @perlboy
|
* 1.30.0 branch * Updates to base build * Update releasenotes.1.30.0.html.md * Updated release notes templates * Corrected typo in Description Addresses: ConsumerDataStandardsAustralia/standards-staging#361 * Updated links Addresses: ConsumerDataStandardsAustralia/standards-staging#362 * Updated Principles text for CX Addresses: ConsumerDataStandardsAustralia/standards-staging#370 * Improved wrapping for long lines Addresses: ConsumerDataStandardsAustralia/standards-staging#371 * Adding version delta and release notes * Updates to 'Revoking consent' Standards Addresses: ConsumerDataStandardsAustralia/standards-maintenance#631 * Removed two outdated statements Addresses: ConsumerDataStandardsAustralia/standards-maintenance#632 * Corrected typo in `cdr_arragement_id` Addresses: ConsumerDataStandardsAustralia/standards-maintenance#629 (comment) * Changed 'Software Package' to 'Software Product' Addresses: ConsumerDataStandardsAustralia/standards-maintenance#629 (comment) * Updated documentation to include link Addresses: ConsumerDataStandardsAustralia/standards-maintenance#629 (comment) * Clarified documentation Addresses: ConsumerDataStandardsAustralia/standards-maintenance#629 (comment) * Updated Non-normative Example Addresses: ConsumerDataStandardsAustralia/standards-maintenance#629 (comment) * Clarified Register endpoint responses Addresses: ConsumerDataStandardsAustralia/standards-maintenance#629 (comment) * Applied change to Register API in NBL Candidate Addresses: ConsumerDataStandardsAustralia/standards-maintenance#629 (comment) * Template code change Change log and version delta details TBC. Addresses: ConsumerDataStandardsAustralia/standards-staging#376 * Removed unused Format column * Updated template and schema mapping Addresses: ConsumerDataStandardsAustralia/standards-staging#376 * Removed outdated statements and examples Addresses: ConsumerDataStandardsAustralia/standards-maintenance#543 * Fixed typo Addresses: ConsumerDataStandardsAustralia/standards-staging#388 * Updated date format Addresses: ConsumerDataStandardsAustralia/standards-staging#310 * Updated based on feedback in MI18 Addresses: ConsumerDataStandardsAustralia/standards-maintenance#543 (comment) * Standards Maintenance Issue #624: Converted solarFeedInTariff.timeVaryingTariffs into an array. Added new mandatory displayName field to solarFeedInTariff.timeVaryingTariffs * Standards Maintenance Issue #625: Added optional period field to various energy rate objects to help support stepped tariff calculation * Standards Maintenance Issue #627: Made changes to EnergyPlanTariffPeriod to allow sharing of banded daily supply charges * Standards Maintenance Issue #627: Corrected bandedDailySupplyCharges to an array. Fixed typos in FDO table * Standards Maintenance Issue #627: Fixed typos in field descriptions * Standards Maintenance Issue #625: Fixed typos in FDO table * Standards Maintenance Issue #624: Fixed typos in FDO table * Standards Maintenance Issue #624: Added new ENUM values CURRENT and VARIABLE to solarFeedInTariff.scheme * Standards Maintenance Issue #625: Corrected diff and release notes including as part of the change * Remove spaces causing extra lines when wrapping * Moving the typo correction to a separate issue * Final updates to 1.30.0 --------- Co-authored-by: Nils Berge <[email protected]> Co-authored-by: Hemang Rathod <[email protected]> Co-authored-by: Mark Verstege <[email protected]>
Standards version 1.30.0 was published on 24/04/2024 incorporating this change from MI18. |
Description
Currently there is conflicting information in the standards about the ID token claims 'sharing_expires_at' and 'refresh_token_expires_at'. The ‘Token Expiry’ section states these claims may be retired from 16th September, however the ‘Scopes and Claims’ section lists that these claims must be supported.
Area Affected
https://consumerdatastandardsaustralia.github.io/standards/#scopes-and-claims
Change Proposed
Remove statements from ‘Scopes and Claims’ section that state 'sharing_expires_at' and 'refresh_token_expires_at' must be supported:
The following additional claims MUST be supported:
DSB Proposed Solution
The proposed solution can be found through the staging link provided in this comment.
The text was updated successfully, but these errors were encountered: