Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties in BankingTransactionDetail objects #414

Closed
nils-work opened this issue Oct 21, 2021 · 3 comments
Closed

Properties in BankingTransactionDetail objects #414

nils-work opened this issue Oct 21, 2021 · 3 comments
Labels
Banking Banking domain APIs Proposal made The DSB has proposed a specific change to the standards to address the change request

Comments

@nils-work
Copy link
Member

nils-work commented Oct 21, 2021

Description

The swagger JSON and the documentation of properties in the BankingTransactionDetail schema seem to be misaligned.

Area Affected

BankingTransactionDetail extendedData schema documentation and related Swagger objects.

Change Proposed

The extendedDescription property shows as x-conditional in the BankingTransactionDetail_extendedData object (but it's not present there), and also shows as required in the BankingTransactionDetail_extendedData_x2p101Payload object (where the property is actually present).

The standards documentation shows that field as mandatory, but the Description includes a condition -
An extended string description. Only present if specified by the extensionUType field

image

Can these details be clarified?

image

DSB Proposed Solution

The current DSB proposal for this issue is in this comment

@CDR-API-Stream
Copy link
Collaborator

This appears to be a defect and it is proposed that it is simply fixed according to the Change Proposed section of the issue.

@CDR-API-Stream CDR-API-Stream added the Proposal made The DSB has proposed a specific change to the standards to address the change request label Aug 17, 2022
@CDR-API-Stream
Copy link
Collaborator

This change has been staged for review: ConsumerDataStandardsAustralia/standards-staging@release/1.19.0...maintenance/414

@CDR-API-Stream
Copy link
Collaborator

This change has been updated to target v1.20.0: ConsumerDataStandardsAustralia/standards-staging@release/1.20.0...maintenance/414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Banking Banking domain APIs Proposal made The DSB has proposed a specific change to the standards to address the change request
Projects
Archived in project
Development

No branches or pull requests

3 participants