Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.4.0] BankingProductFee feeType adds Variable which is a new payload version #310

Closed
perlboy opened this issue Aug 30, 2020 · 1 comment

Comments

@perlboy
Copy link

perlboy commented Aug 30, 2020

Description

BankingProductFee had the enumeration of feeType altered to include VARIABLE as per the changelog:
image

As a consequence, BankingProductDetail (V4) and BankingAccountDetail (V2) are now a new payload version resulting in a new payload version for Get Account Detail and Get Product Detail.

Area Affected

Get Account Detail, Get Product Detail, BankingProductDetail, BankingAccountDetail, ResponseBankingProductById, ResponseBankingAccountById.

Change Proposed

Increment the payload versions of the endpoints affected, increment downstream payloads and responses.

@CDR-API-Stream
Copy link
Collaborator

No change will be adopted for this issue. The decision is not to change the payload versions or increment the API endpoint versions. Because the change affected a future dated release of the associated endpoints, the change was incorporated into Get Product Details V3 and Get Account Details V2. This is consistent with the approach the DSB has taken in the past where a change to the model for a version of an endpoint that is not yet an obligation for data holders would not result in a versioning of the affected endpoint.

Since this change, further clarification has been provided by the DSB on changes to the schema models going forwards. Changes that result in a breaking change to one or more affected end points will result in the schema dependencies being versioned.

This position was approved by the Data Standards Chair.

This issue will be closed accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants