-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gap in CDS specs around the mandatory nature of 'redirect_uri' in the Token Request #288
Comments
Umm @cdswizard FWIW OAUTH/OIDC don't require |
Here's an example of a token endpoint call from the FAPI conformance suite: (line breaks added to improve readability)
I believe @cdswizard is correct that the example should include redirect_uri. The example probably also doesn't need to include |
Apologies, it was me with my wires crossed, right you are @jogu and @cdswizard, |
This has been staged here: |
There appears to be a gap in the CDS specs around the mandatory nature of 'redirect_uri' in the Token Request.
Neither the specs nor the non-normative example seem to suggest it is required:
Under Client Authentication (Data Recipients calling Data Holders), the mandatory fields
(grant_type, code, client_id, etc.) do not include the 'redirect_uri', even though the Token endpoint is mentioned.
The non-normative example also doesn't include it:
POST /token HTTP/1.1
Host: www.holder.com.au
Content-Type: application/x-www-form-urlencoded
grant_type=authorization_code&
code=i1WsRn1uB1&
client_id=s6BhdRkqt3&
client_assertion_type=urn%3Aietf%3Aparams%3Aoauth%3Aclient-assertion-type%3Ajwt-bearer&
client_assertion=eyJhbGciOiJQUzI1NiIsInR5cCI6IkpXVCIsImtpZCI6IjEyNDU2In0.ey ...
However, from looking in OAUTH/OIDC/FAPI it appears that it is mandated:
In OAUTH (4.1.3) Access Token Request:
REQUIRED, if the 'redirect_uri' parameter was included in the authorization request...
In OIDC (3.1.3.2):
Ensure that the redirect_uri parameter value is identical to the redirect_uri parameter value that was included in the initial Authorization Request.
But we also know from FAPI-R (5.2.2):
"shall require the redirect_uri parameter in the authorization request;"
This suggests that FAPI demands 'redirect_uri' be present in the Authorization Request, hence
it must be included in the Token Request (so that it can be matched/validated against what was sent in the Authorization Request).
Am I missing something here?
The text was updated successfully, but these errors were encountered: