Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eth secp AWS KMS bulk loading #770

Closed
7 tasks done
jframe opened this issue Apr 24, 2023 · 1 comment · Fixed by #889
Closed
7 tasks done

Eth secp AWS KMS bulk loading #770

jframe opened this issue Apr 24, 2023 · 1 comment · Fixed by #889
Assignees
Labels
TeamCerberus Under active development by TeamCerberus @Consensys

Comments

@jframe
Copy link
Contributor

jframe commented Apr 24, 2023

Add bulk loading of AWS secp256k1 keys in web3signer. This mirrors the bulk loading functionality of BLS signing in Web3signer to load multiple keys from a single configuration.

  • Add AWS param to the Eth1Config
  • Create a secp AWS bulk loader to retrieve key names and create ArtifactSigners
  • Add support to KMS tags
  • Update runner to secp AWS bulk loader
  • Update runner to add healthcheck for AWS bulk loading
  • Acceptance test (see acceptance-tests/src/test/java/tech/pegasys/web3signer/tests/bulkloading/AwsSecretsManagerAcceptanceTest.java)
  • Performance test bulk loading to ensure is comparable to secrets manager bulk loading used for BLS
@jframe jframe added the TeamCerberus Under active development by TeamCerberus @Consensys label Apr 24, 2023
@jframe jframe changed the title Eth secp key bulk loading Eth secp AWS bulk loading Jul 4, 2023
@gfukushima gfukushima changed the title Eth secp AWS bulk loading Eth secp AWS KMS bulk loading Jul 9, 2023
@siladu siladu added the blocked label Jul 24, 2023
@jframe jframe self-assigned this Aug 21, 2023
@jframe jframe removed the blocked label Aug 21, 2023
@jframe jframe added the doc-change-required Indicates an issue or PR that requires doc to be updated label Aug 29, 2023
@jframe
Copy link
Contributor Author

jframe commented Sep 6, 2023

Performance test with 10, 1000 and 10000 keys. In AWS the keys aren't deleted immediately and are marked for deletion. And the API to list keys also returns keys marked for deletion so each test run affects further tests to a degree. I've included the number of keys marked for deletion in the test results too so this can be factored into the results.

Marked for Deletion Keys Active Keys Time Taken
1262 10 00:00:44.177
1272 1,000 00:01:45.199
12273 10,000 00:10:36.263

@jframe jframe mentioned this issue Sep 12, 2023
3 tasks
@alexandratran alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TeamCerberus Under active development by TeamCerberus @Consensys
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants