Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplication on EpochProcessorElectra #8852

Closed
lucassaldanha opened this issue Nov 27, 2024 · 0 comments · Fixed by #8856
Closed

Remove duplication on EpochProcessorElectra #8852

lucassaldanha opened this issue Nov 27, 2024 · 0 comments · Fixed by #8856
Assignees
@StefanBratanov
Labels
Epic Electra Issues required to implement Electra upgrade

Comments

@lucassaldanha
Copy link
Member

Due to some of the changes on the Electra spec, we ended up duplicating a few methods between EpochProcessorElectra and AbstractBlockProcessing.

Due to their global scope on consensus-spec, this is not an issue there. However, in Teku's implementation, we need to move them somewhere sensible and remove the duplication.

Duplicated methods:

  • isValidDepositSignature
  • addValidatorToRegistry
@lucassaldanha lucassaldanha added the Epic Electra Issues required to implement Electra upgrade label Nov 27, 2024
@StefanBratanov StefanBratanov self-assigned this Nov 27, 2024
@StefanBratanov StefanBratanov mentioned this issue Nov 27, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanBratanov StefanBratanov

Labels
Epic Electra Issues required to implement Electra upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor BlockProcessor and EpochProcessor StefanBratanov/teku
2 participants
@lucassaldanha @StefanBratanov