Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Stop supporting unused arrays in Registries #788

Closed
6 tasks
alainncls opened this issue Oct 31, 2024 · 0 comments · Fixed by #799
Closed
6 tasks

[TASK] Stop supporting unused arrays in Registries #788

alainncls opened this issue Oct 31, 2024 · 0 comments · Fixed by #799
Assignees

Comments

@alainncls
Copy link
Collaborator

alainncls commented Oct 31, 2024

3 of our Registries have arrays to keep track of the number of items they registered.
While this can be useful to easily get the number of items they registered, this data can easily be accessed off chain via the subgraph.
Also, this can lead to "Gas-Griefing Vulnerability" in some cases.

Tasks

While we can't just delete the variable itself (the Registries being Upgradeable), we should keep the variables but stop using them (pushing into the arrays, reading from the arrays, deleting from the array, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released
2 participants