Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the GKR API to add instances #1424

Open
Tabaie opened this issue Feb 17, 2025 · 0 comments
Open

Enable the GKR API to add instances #1424

Tabaie opened this issue Feb 17, 2025 · 0 comments
Assignees
Labels
consolidate strengthen an existing feature doc-change-required Indicates an issue or PR that requires doc to be updated

Comments

@Tabaie
Copy link
Contributor

Tabaie commented Feb 17, 2025

Currently all the instances of a GKR sub-circuit have to be defined at once. This can be cumbersome since it gives the user access to the output variables only after they are all defined. For example, if the user is defining hash permutations, the results of which are needed right away, they would have to independently define a hint that computes the output, and later equate that with the Exported values from the gkr API.

Instead it is desirable for the user to be able to define the whole circuit (by allowing the Import function to take no arguments, or better yet renaming it to NewVariable). And then having a function called NewInstance/NewInstances that takes assignments or dependencies for the input values and returns assignments for output variables.

The complexity in this will be that the GKR Solve hint would have to be called multiple times (for every invocation of Export or NewInstance).

@Tabaie Tabaie self-assigned this Feb 17, 2025
@Tabaie Tabaie added doc-change-required Indicates an issue or PR that requires doc to be updated consolidate strengthen an existing feature labels Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consolidate strengthen an existing feature doc-change-required Indicates an issue or PR that requires doc to be updated
Projects
None yet
Development

No branches or pull requests

1 participant