-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize health syncing status via query parameter #4013
Customize health syncing status via query parameter #4013
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
If this is a helpful change more generally, could potentially look at making a spec change on eth2.0-apis so that it's part of the standard api...
@jmcruz1983 could you take a look at the CLA for me? thanks... |
eb986da
to
2f7b91c
Compare
FYI @rolfyone |
Yeah it has approved your GitHub user but doesn't seem to be able to map the commits to that user. From the comment it left above:
|
May need to edit the commit so it has an email address with it (can just be the one GitHub generates rather than your real one) and do a force push to replace the commit. |
Thanks @ajsutton |
- use request parameter to override default syncing status - return default status if wrong parameter passed - add tests to cover different scenarios
2f7b91c
to
813da8f
Compare
Customize health check status when node is syncing
Documentation
Health check syncing status can be overridden with custom value passed via query parameter
syncing_status
.Therefore, it would be compatible with kubernetes standard health check where 200-399 statuses are considered healthy.
Changelog