Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Buffer's CPtr by std::span #5178

Open
chillenzer opened this issue Oct 18, 2024 · 0 comments
Open

Replace Buffer's CPtr by std::span #5178

chillenzer opened this issue Oct 18, 2024 · 0 comments
Labels
refactoring code change to improve performance or to unify a concept but does not change public API

Comments

@chillenzer
Copy link
Contributor

chillenzer commented Oct 18, 2024 •
edited
Loading

Looking at CPtr in

picongpu/include/pmacc/memory/buffers/Buffer.hpp

Line 197 in ef239f0

struct CPtr
it is the same as a std::span with a reduced interface. Should we consider moving to std::span? I've been using it on device in other codes just fine.
@chillenzer chillenzer added the refactoring code change to improve performance or to unify a concept but does not change public API label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring code change to improve performance or to unify a concept but does not change public API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chillenzer