Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for dotnet core #5

Open
oliwennell opened this issue Feb 12, 2018 · 8 comments
Open

Support for dotnet core #5

oliwennell opened this issue Feb 12, 2018 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@oliwennell
Copy link
Contributor

oliwennell commented Feb 12, 2018

Investigate what's required.

Known issues:

  • We assume Windows style directory separators (C:\blah) - for this should be able to cherry-pick b7efed3 from the mono branch
  • MSBuildWorkspace not available

Known potential issues:

  • Relying on app-domains for isolation when running tests using NUnit Engine, not sure what happens when using the .NET Standard version?
@oliwennell oliwennell added the enhancement New feature or request label Mar 23, 2018
@oliwennell oliwennell self-assigned this Apr 20, 2018
@dcook-net
Copy link

@oliwennell do you want a hand with this? I was just thinking about it this morning....which is how I found this issue.

@oliwennell
Copy link
Contributor Author

I'd welcome your help if you're up for it @dcook-net :)

I did some initial investigation but i was quite a while ago now.
Perhaps if you have an initial look and we can talk through what you find?

@dcook-net
Copy link

Cloning...

@robertlyson
Copy link

Just thought about creating a global tool for fettle, so we could simplify how the tool is run. And this is how I landed here.
@dcook-net how it went with conversion to the core? Can I help somehow?

@robertlyson
Copy link

Support for Microsoft.CodeAnalysis.MSBuild.MSBuildWorkspace(dotnet/roslyn#17974) is missing in core.

@dcook-net
Copy link

@robertlyson I didnt get very far, mostly due to other commitments tbh. I doesn't currently build.

@oliwennell
Copy link
Contributor Author

Hey @robertlyson , thank you for offering to help :) 👍

Right now what would help is a list of "known issues" that we need to resolve before we can support dotnet core. I see that you've mentioned an issue with MSBuildWorkspace, if you're able to find out any others and list them here that's be great.

Alternatively, you could look into how we could get around the MSBuildWorkspace issue you mentioned.

@dcook-net
Copy link

dcook-net commented Mar 25, 2019

Just thought about creating a global tool for fettle, so we could simplify how the tool is run. And this is how I landed here.

@robertlyson This is a good idea. Personally I think this combined with DotNetCliToolReference support would be fantastic (FYI - this is also how Stryker works). This would give users complete flexibility in how people consume fettle.
Global Tools are great on the command line, but are a little messy inside Docker.
Just thinking out load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants