Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent labelling of partitions in priors panel #57

Open
tgvaughan opened this issue Jun 8, 2023 · 2 comments
Open

Inconsistent labelling of partitions in priors panel #57

tgvaughan opened this issue Jun 8, 2023 · 2 comments

Comments

@tgvaughan
Copy link
Contributor

For partitions which have been relabeled, it seems BEAUti (2.7.4) still uses the old names in the parameter descriptions in the priors panel:
Screenshot 2023-06-08 at 17 38 46

@rbouckaert
Copy link
Member

@tgvaughan I am not completely sure what the expected behaviour is. For the example you gave, there are two things that can be relabeled: the alignment name and the site model name. After renaming the site model, the name displayed will be the renamed site model if the label is of the form s:$(n) and is the name of the alignment is it is $(n). The BeautiDoc.renamePartition() method takes care of renaming. Is this not what is expected?

@tgvaughan
Copy link
Contributor Author

Hi Remco, sorry for letting this issue go stale. And you're absolutely right. I think I was just confused by the presence of the "s:" prefix in the partition name. Would it make sense to drop that prefix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants