Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEAUti cloning of clocks sometimes clones tree prior #34

Open
rbouckaert opened this issue Nov 27, 2022 · 3 comments
Open

BEAUti cloning of clocks sometimes clones tree prior #34

rbouckaert opened this issue Nov 27, 2022 · 3 comments

Comments

@rbouckaert
Copy link
Member

To replicate:

  • choose STACEY template,
  • import a number of alignments,
  • set first partition clock to ORC
  • clone other clocks from first partition

Several PIOMSCoalescentDistributions appear while there should be only one.

@rbouckaert
Copy link
Member Author

Marking the PIOMSCoalescentDistributions not cloneable by overriding notCloneable like so:

 @Override
   public boolean notCloneable() {
        return true;
    }

fixes the issue. It feels that it may be too hard to make the logic in BeautiDoc.deepCopyPlugin work it out by itself.

@bjoelle
Copy link

bjoelle commented Jun 29, 2023

FYI I've had the same issue with an FBD tree prior being cloned (I imported two partitions, then accidentally linked the clock model, and when unlinking I got two tree priors) so it doesn't seem limited to STACEY.

@rbouckaert
Copy link
Member Author

Thanks for the bug report. Now wondering whether perhaps the TreeDistribution or the FBD tree prior should have the same notClonable method as PIOMSCoalescentDistributions to get around this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants