Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ObservableProperty Generated Code Properties Virtual? #543

Closed
hounddog22030 opened this issue Dec 21, 2022 · 4 comments
Closed

Make ObservableProperty Generated Code Properties Virtual? #543

hounddog22030 opened this issue Dec 21, 2022 · 4 comments
Labels
duplicate 👥 Indicates that an identical issue or PR already exists feature request 📬 A request for new changes to improve functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit

Comments

@hounddog22030
Copy link

I have found myself in a situation where I would like to mock (Moq) some of the properties generated. Without them being virtual, this is not possible. Has this been taken into consideration as a possibility (to generate the properties as virtual)?

@Sergio0694 Sergio0694 transferred this issue from CommunityToolkit/MVVM-Samples Dec 21, 2022
@Sergio0694 Sergio0694 added feature request 📬 A request for new changes to improve functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Dec 21, 2022
@Sergio0694
Copy link
Member

This will be supported once partial properties are available. There are no plans to add this to the field annotations.

@hounddog22030
Copy link
Author

What are partial properties?

@Sergio0694
Copy link
Member

See the proposal here: dotnet/csharplang#6420. Might possibly be available in C# 12 🙂

@Sergio0694
Copy link
Member

Closing this, as it's superseded by #555.

@Sergio0694 Sergio0694 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 4, 2023
@Sergio0694 Sergio0694 added the duplicate 👥 Indicates that an identical issue or PR already exists label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate 👥 Indicates that an identical issue or PR already exists feature request 📬 A request for new changes to improve functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit
Projects
None yet
Development

No branches or pull requests

2 participants