Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add Currency format to TextBoxExtensions #4188

Closed
omikhailov opened this issue Aug 20, 2021 · 4 comments · May be fixed by #4469
Closed

[Feature] Add Currency format to TextBoxExtensions #4188

omikhailov opened this issue Aug 20, 2021 · 4 comments · May be fixed by #4469
Labels
feature request 📬 A request for new changes to improve functionality good first issue Issues identified as good for first-time contributors Hacktoberfest Hacktoberfest is a month-long celebration of open source software help wanted Issues identified as good community contribution opportunities In-PR 🚀
Milestone
8.0

Comments

@omikhailov
Copy link

Describe the problem this feature would solve

TextBoxExtensions has support for Decimal validation type, but this kind of validation does not allow currency signs, e.g. $ or €.

Describe the solution

Add Currency to ValidationType enum and update TextBoxExtensions to accept values in {0:C} string format, not just {0:N} like in Decimal mode.
@omikhailov omikhailov added the feature request 📬 A request for new changes to improve functionality label Aug 20, 2021
@ghost
Copy link

ghost commented Aug 20, 2021

Hello, 'omikhailov! Thanks for submitting a new feature request. I've automatically added a vote 👍 reaction to help get things started. Other community members can vote to help us prioritize this feature in the future!

@XAML-Knight XAML-Knight added this to the 7.1.1 milestone Oct 7, 2021
@michael-hawker
Copy link
Member

Moving feature to next milestone out of hotfix release.

@michael-hawker michael-hawker modified the milestones: 7.1.1, 7.2/8.0? Oct 11, 2021
@michael-hawker michael-hawker added good first issue Issues identified as good for first-time contributors Hacktoberfest Hacktoberfest is a month-long celebration of open source software help wanted Issues identified as good community contribution opportunities labels Oct 11, 2021
@NaftoliOst
Copy link

Hi,
Can I claim this issue?

@olegL1337 olegL1337 mentioned this issue Dec 16, 2021
Closed
11 tasks
@NaftoliOst NaftoliOst mentioned this issue Jan 25, 2022
Open
11 tasks
@ghost ghost added the In-PR 🚀 label Jan 25, 2022
@michael-hawker
Copy link
Member

Using issue for discussion as PRs are in flux.

@NaftoliOst was talking with @Arlodotexe about culture variants. We were thinking maybe we should extend the IsNumeric and IsDecimal functions in the .NET Community Toolkit to accept culture arguments too? (FYI @Sergio0694)

Then we could have a new Culture attached property for the regex extensions we could use to configure the culture setting for Numeric, Decimal, and Currency.

Thoughts?

@CommunityToolkit CommunityToolkit locked and limited conversation to collaborators Jul 29, 2022
@LalithaNadimpalli LalithaNadimpalli converted this issue into discussion #4683 Jul 29, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees
No one assigned
Labels
feature request 📬 A request for new changes to improve functionality good first issue Issues identified as good for first-time contributors Hacktoberfest Hacktoberfest is a month-long celebration of open source software help wanted Issues identified as good community contribution opportunities In-PR 🚀
Projects
Windows Community Toolkit
Status: Done
Milestone
8.0
Development

Successfully merging a pull request may close this issue.

Add Currency validation to TextBoxExtensions NaftoliOst/WindowsCommunityToolkit
4 participants
@michael-hawker @NaftoliOst @omikhailov @XAML-Knight