Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discard null clicked items #4454

Closed
wants to merge 1 commit into from
Closed

discard null clicked items #4454

wants to merge 1 commit into from

Conversation

vgromfeld
Copy link
Contributor

Fixes #4453 4453

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

ListViewBase.ItemClick can be triggered with a null ItemClickEventArgs.ClickedItem even if it does not contain any null item.
The is a system XAML issue.

What is the new behavior?

I'm adding a new DiscardNullClickedItemsProperty attached property to ListviewExtensions.
If this property is set to:

  • True: any ListViewBase.ItemClick event triggered with a null ItemClickEventArgs.ClickedItem will be discarded.
  • False: The ItemClickEventArgs.ClickedItem vaklue is always provided to the attached ICommand (default value).

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

I've also updated a bit the code to shortened it and prevent a NullReferenceException in OnListViewBaseItemClick

@ghost
Copy link

ghost commented Jan 10, 2022

Thanks vgromfeld for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi January 10, 2022 17:26
@ghost ghost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Jan 10, 2022
@Arlodotexe Arlodotexe self-requested a review January 10, 2022 19:10
@Arlodotexe
Copy link
Member

We're not planning to merge this PR for 2 reasons

  • The original issue turned out to be an underlying platform bug
  • This is adding a new feature as a workaround, not fixing existing code in the toolkit.

@Arlodotexe Arlodotexe closed this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-hawker michael-hawker Awaiting requested review from michael-hawker

@azchohfi azchohfi Awaiting requested review from azchohfi

@Arlodotexe Arlodotexe Awaiting requested review from Arlodotexe

Assignees
No one assigned
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an option to discard null ItemClickEventArgs.ClickedItem before executing ListViewExtensions.Command
2 participants
@vgromfeld @Arlodotexe