Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlink command extension is always executing the attached command #3171

Closed
1 task
vgromfeld opened this issue Mar 18, 2020 · 1 comment · Fixed by #3172
Closed
1 task

Hyperlink command extension is always executing the attached command #3171

vgromfeld opened this issue Mar 18, 2020 · 1 comment · Fixed by #3172
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥
Milestone

Comments

@vgromfeld
Copy link
Contributor

Describe the bug

The command set to an hyperlink using HyperlinkExtensions.Command attached property is always executed. It does not consider the ICommand.CanExecute() value.

  • Is this bug a regression in the toolkit? If so, what toolkit version did you last see it work:

Steps to Reproduce

Steps to reproduce the behavior:

  1. Attach a disabled command to an Hyperlink control using HyperlinkExtensions.Command
  2. Click on the link
  3. Observe that the command is executed

Expected behavior

The attached command should not be executed.

Environment

NuGet Package(s): 6.0.0.0

Package Version(s):

@vgromfeld vgromfeld added the bug 🐛 An unexpected issue that highlights incorrect behavior label Mar 18, 2020
@ghost ghost added the needs triage 🔍 label Mar 18, 2020
@ghost
Copy link

ghost commented Mar 18, 2020

Hello vgromfeld, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@ghost ghost added the In-PR 🚀 label Mar 18, 2020
@michael-hawker michael-hawker added this to the 6.1 milestone Mar 18, 2020
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Mar 19, 2020
@ghost ghost locked as resolved and limited conversation to collaborators May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants