Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port TabbedCommandBar #93

Closed
6 tasks
niels9001 opened this issue Jun 14, 2023 · 4 comments · Fixed by #243
Closed
6 tasks

Port TabbedCommandBar #93

niels9001 opened this issue Jun 14, 2023 · 4 comments · Fixed by #243
Assignees
Labels
Priority-2 Priority 2

Comments

@niels9001
Copy link
Collaborator

Base Porting Checklist

Preview Give feedback

Known Issues

Preview Give feedback
No tasks being tracked yet.

Improvements

Preview Give feedback
No tasks being tracked yet.

Notable Changes

N/A

@michael-hawker
Copy link
Member

michael-hawker commented Jul 7, 2023

Talked to @yoshiask and they're going to take an initial look at it, thanks!

@niels9001 if we get the initial port in, maybe you can take a quick look at the template for styling?

@niels9001
Copy link
Collaborator Author

Talked to @yoshiask and they're going to take an initial look at it, thanks!

@niels9001 if we get the initial port in, maybe you can take a quick look at the template for styling?

Awesome! Yep, for sure - happy to help!

@mdtauk
Copy link

mdtauk commented Jul 22, 2023

Having a quick look at Paint's VisualTree...

<Ribbon>
    <ScrollContentPresenter>
        <Grid> // With columns for each toolbar/group
            <Border>
                <CollapsedToolbar> <!-- Contents change as width narrows and isCollapsed changes -->
                    <Grid>
                        <Border x:Name="ContentHolder"> <!-- contains the Buttons that display in this toolbar -->
                            <!-- ... Custom Controls containing Buttons, SplitButtons, etc -->
                        </Border>
                        <Button x:Name="CollapsedButton"> <!-- The Button that displays when the toolbar isCollapsed -->
                    <TextBlock> <!-- The Name of the toolbar/group -->
  • The CollapsedButton is hidden when the CollapsedToolbar isCollapsed = False
  • The Contents of the CollapsedToolbar render in a flyout when it is collapsed, whilst the CollapsedButton remains in the Ribbon

image

image

image

I would guess there are Visual States that collapse as the width changes and goes below a threshold.

@mdtauk
Copy link

mdtauk commented Jul 22, 2023

image
Office and Outlook puts their toolbar controls within a floating panel

image
Something like this perhaps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority-2 Priority 2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants