Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several packages are incorrectly named on Nuget #43

Closed
michael-hawker opened this issue May 4, 2023 · 7 comments
Closed

Several packages are incorrectly named on Nuget #43

michael-hawker opened this issue May 4, 2023 · 7 comments
Assignees

Comments

@michael-hawker
Copy link
Member

The Sizers are in the CommunityToolkit.WinUI.Controls namespace, but the package doesn't really reflect that.

The package name should have the Controls part in it as well, but currently it is omitted.

Not sure where that's getting dropped as it's in the project filename: CommunityToolkit.WinUI.Controls.Sizers.csproj.

But the package is instead CommunityToolkit.WinUI.Sizers.

@Arlodotexe Arlodotexe self-assigned this May 11, 2023
@Arlodotexe
Copy link
Member

@michael-hawker We'll get that fixed. That means we'll need to mark the published CommunityToolkit.WinUI.Sizers package as deprecated as well, how do we go about that?

@Arlodotexe
Copy link
Member

Possibly the same issue with the Primitives package? It should be CommunityToolkit.WinUI.Controls.Primitives if it's based on the file name 🤔

image

@Arlodotexe
Copy link
Member

Same problem with Triggers. Something has clearly been misconfigured, and other packages may be affected. Needs investigation.

image

@michael-hawker
Copy link
Member Author

Triggers I'm not sure if it needs it as they're not controls? Definitely Primitives.

To deprecate the package can be done in the Azure Artifacts. Not sure who has permissions to do that besides me, Sergio might.

@Arlodotexe Arlodotexe changed the title CommunityToolkit.*.Sizers should be CommunityToolkit.*.Controls.Sizers Several packages are incorrectly named on Nuget May 12, 2023
@Arlodotexe
Copy link
Member

@niels9001 The PackageId defaults to the name of the component. We should be setting the PackageId for these manually.

image

@Arlodotexe
Copy link
Member

Arlodotexe commented May 23, 2023

@Arlodotexe Arlodotexe moved this to 👀 In review in Toolkit 8.x May 31, 2023
@Arlodotexe Arlodotexe moved this from 👀 In review to 🔖 Ready in Toolkit 8.x May 31, 2023
@michael-hawker
Copy link
Member Author

Unlisted the packages with the old identities.

@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Toolkit 8.x Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants