Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommunityToolkit.WinUI.UI.dll incompatibility with MalwareBytes because of big comments field. Suggest shortening it. #253

Closed
3 of 24 tasks
jaimecbernardo opened this issue Oct 6, 2023 · 2 comments

Comments

@jaimecbernardo
Copy link

Describe the bug

In PowerToys, some users started having issues with PowerToys.Settings.exe, where we use CommunityToolkit: microsoft/PowerToys#28988

After investigating, it seems that the main factor was that the users with the issues were using Malwarebytes, so we've submitted a report there too.

Turns out the engine was flagging CommunityToolkit.WinUI.UI.dll because the Comments field in the version info of the dll is quite long, whith is non-standerd:
https://forums.malwarebytes.com/topic/303158-malwarebytes-and-powertoys-incompatibility/?do=findComment&comment=1593489

The suggestion was to shorten this field. They'll still be release a fix in malwarebytes, but shortening this field might help in case there are issues with different antivirus software.

Thank you 😄

Steps to reproduce

Install PowerToys and Malwarebytes 4.6.4.286 in the same computer and try to open Settings of PowerToys. Nothing happens and malwarebytes engine spikes to use a full CPU.
Not saying this is something wrong with Community Toolkit, but following expected standards might help in compatibility with other security software.

Expected behavior

PowerToys Settings to open.

Screenshots

No response

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 10 21H2 (Build 19044)
  • Windows 10 22H2 (Build 19045)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

22621

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Windows 10, version 2104 (Build 20348)
  • Windows 11, version 22H2 (Build 22000)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

Yes, but only if others can assist.

@michael-hawker
Copy link
Member

So for 7.x and below we were using the csproj Description field, as that's what appears on NuGet.org. It wasn't as clear to us from the documentation that it is embedded into the assembly and could cause this type of issue. (It does appear as if the MalwareBytes folks added this to their database on that thread?)

For 8.0 we still use Description though have not put the same level of detail (Basically just "This package contains Extensions") in there and instead moved to the new NuGet readme system (See #185).

I've opened a doc bug for future guidance/standard practice for others: https://github.com/NuGet/docs.microsoft.com-nuget/issues/3159

We don't plan to service the 7.x line, so the best course of action is to update to the 8.0 equivalents which won't have this issue. If something is missing that you need, please let us know.

@michael-hawker michael-hawker closed this as not planned Won't fix, can't repro, duplicate, stale Oct 9, 2023
@michael-hawker
Copy link
Member

@Arlodotexe we may want to triple-check any of the existing projects, but maybe also put a note in the Tooling template readme about this field should be a brief description and then call out using the NuGet readme as we've done for our packages. Don't think we updated the template for that yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants