From 67e61003924bc01db56d200e6d2f05d9c1a0c047 Mon Sep 17 00:00:00 2001 From: michael-hawker <24302614+michael-hawker@users.noreply.github.com> Date: Mon, 14 Aug 2023 13:24:57 -0700 Subject: [PATCH] Fixes issues with the build script in detecting dump files to upload and analyze dorny/paths-filter only works on detecting changes to git files not untracked files Add Blame to test runner and upload of sequence file --- .github/workflows/build.yml | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b38aea89..e7079d4c 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -159,7 +159,7 @@ jobs: - name: Run experiment tests against ${{ env.TEST_PLATFORM }} id: test-platform - run: vstest.console.exe ./tooling/**/CommunityToolkit.Tests.${{ env.TEST_PLATFORM }}.build.appxrecipe /Framework:FrameworkUap10 /logger:"trx;LogFileName=${{ env.TEST_PLATFORM }}.trx" + run: vstest.console.exe ./tooling/**/CommunityToolkit.Tests.${{ env.TEST_PLATFORM }}.build.appxrecipe /Framework:FrameworkUap10 /logger:"trx;LogFileName=${{ env.TEST_PLATFORM }}.trx" /Blame - name: Create test reports run: | @@ -182,26 +182,24 @@ jobs: # https://github.com/dorny/paths-filter#custom-processing-of-changed-files - name: Detect If any Dump Files - uses: dorny/paths-filter@v2.11.1 - id: filter - with: - list-files: shell - filters: | - dump: - - added: '${{ github.workspace }}/CrashDumps/*.dmp' + id: detect-dump + if: always() + working-directory: ${{ github.workspace }} + run: | + echo "DUMP_FILE=$(Get-ChildItem .\CrashDumps\*.dmp -ErrorAction SilentlyContinue)" >> $env:GITHUB_OUTPUT - name: Artifact - WER crash dumps uses: actions/upload-artifact@v3 - if: ${{ steps.filter.outputs.dump == 'true' && (env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '') && always() }} + if: ${{ (env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '') && always() }} with: name: CrashDumps-${{ matrix.platform }} path: '${{ github.workspace }}/CrashDumps' - name: Analyze Dump - if: ${{ steps.filter.outputs.dump == 'true' && (env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '') && always() }} + if: ${{ steps.detect-dump.outputs.DUMP_FILE != '' && (env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '') && always() }} run: | dotnet tool install --global dotnet-dump - dotnet-dump analyze ${{ steps.filter.outputs.dump_files }} -c "clrstack" -c "pe -lines" -c "exit" + dotnet-dump analyze ${{ steps.detect-dump.outputs.DUMP_FILE }} -c "clrstack" -c "pe -lines" -c "exit" wasm-linux: runs-on: ubuntu-latest