Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 9 Partial Properties For Sample Options #231

Open
20 tasks
michael-hawker opened this issue Nov 23, 2024 · 2 comments
Open
20 tasks

.NET 9 Partial Properties For Sample Options #231

michael-hawker opened this issue Nov 23, 2024 · 2 comments
Labels
dev loop ➰ For issues that impact the core dev-loop of building experiments enhancement New feature or request sample app 🖼 source generator ⚙️

Comments

@michael-hawker
Copy link
Member

michael-hawker commented Nov 23, 2024

Describe the bug

Would be nice to convert to something like:

[ToolkitSample(...)]
public sealed partial class MySample : Page
{
    [ToolkitSampleNumericOption(min: 0.0, max: 1.0)]
    public partial double MyRangeValue { get; set; } = 0.5;
}

This can make it clearer to see the properties in the code-behind (and use them there) as well.

Steps to reproduce

N/A

Expected behavior

N/A

Screenshots

No response

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

Yes, but only if others can assist.

@michael-hawker michael-hawker added the bug 🐛 Something isn't working label Nov 23, 2024
@michael-hawker
Copy link
Member Author

Maybe we could get away with having "Numeric" and "Bool" option as we'd be able to detect the type of the partial now too?

@michael-hawker michael-hawker added enhancement New feature or request dev loop ➰ For issues that impact the core dev-loop of building experiments sample app 🖼 source generator ⚙️ and removed bug 🐛 Something isn't working labels Nov 23, 2024
@Arlodotexe
Copy link
Member

Maybe we could get away with having "Numeric" and "Bool" option as we'd be able to detect the type of the partial now too?

The attribute parameters are different for each type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev loop ➰ For issues that impact the core dev-loop of building experiments enhancement New feature or request sample app 🖼 source generator ⚙️
Projects
None yet
Development

No branches or pull requests

2 participants