Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some sample assets not showing in UWP #100

Closed
Tracked by #195
Arlodotexe opened this issue Jul 10, 2023 · 4 comments · Fixed by #129
Closed
Tracked by #195

Some sample assets not showing in UWP #100

Arlodotexe opened this issue Jul 10, 2023 · 4 comments · Fixed by #129
Assignees

Comments

@Arlodotexe
Copy link
Member

Background

          Hmm, this isn't showing up on the UWP sample... (Was also having trouble seeing the code samples in the sample app). Maybe something for us to investigate outside the PR? Or is this a faux-png image that's causing issues maybe? Worked in WASDK no problem though...

Originally posted by @michael-hawker in CommunityToolkit/Windows#109 (comment)

Problem

Some sample assets are not showing under the UWP in the HeaderedControl.Samples project.

WinAppSDK:
image

UWP:
image

WASM:
image

michael-hawker referenced this issue in CommunityToolkit/Windows Jul 10, 2023
Didn't see it working on Uno, but not sure if related to #119 or issue with caching or something...
Will have to add another sample and see after?
michael-hawker referenced this issue in CommunityToolkit/Windows Jul 10, 2023
Didn't see it working on Uno, but not sure if related to #119 or issue with caching or something...
Will have to add another sample and see after?
michael-hawker referenced this issue in CommunityToolkit/Windows Jul 11, 2023
Didn't see it working on Uno, but not sure if related to #119 or issue with caching or something...
Will have to add another sample and see after?
michael-hawker referenced this issue in CommunityToolkit/Windows Jul 11, 2023
Didn't see it working on Uno, but not sure if related to #119 or issue with caching or something...
Will have to add another sample and see after?
michael-hawker referenced this issue in CommunityToolkit/Windows Jul 11, 2023
Didn't see it working on Uno, but not sure if related to #119 or issue with caching or something...
Will have to add another sample and see after?
@michael-hawker
Copy link
Member

Ugh, I needed to test something with an image... we're going to need to fix this in the next couple of weeks before release... CommunityToolkit/Windows#136

Don't think we should hold up the other PR, but would have liked to know if that's working and an issue with WASDK or not.

Worst case, hopefully we could fix forward, I'm not sure why it doesn't behave/attach properly on the first load.

michael-hawker referenced this issue in CommunityToolkit/Windows Jul 13, 2023
Didn't see it working on Uno, but not sure if related to #119 or issue with caching or something...
Will have to add another sample and see after?
@Arlodotexe Arlodotexe transferred this issue from CommunityToolkit/Windows Jul 17, 2023
@michael-hawker michael-hawker moved this to 🔖 Ready in Toolkit 8.x Jul 18, 2023
@michael-hawker
Copy link
Member

@Arlodotexe you said JPGs are working but not PNGs or something?

@michael-hawker
Copy link
Member

I wonder if this is because we don't automatically set the Build Action to Content and the Copy to Output Directory as Copy if newer? We should probably have a hook here like we do to automatically include XAML pages to include images, right?

@michael-hawker
Copy link
Member

Hmm, the Converters.Samples project does that in the sample project, but it doesn't work for the BoolToVisibilityConverter sample still...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants