Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample projects don't allow for WinUI 2/3 dependencies #165

Closed
Arlodotexe opened this issue Jun 16, 2022 · 0 comments · Fixed by #199
Closed

Sample projects don't allow for WinUI 2/3 dependencies #165

Arlodotexe opened this issue Jun 16, 2022 · 0 comments · Fixed by #199
Labels
dev loop ➰ For issues that impact the core dev-loop of building experiments enhancement Improvement to an existing feature templating

Comments

@Arlodotexe
Copy link
Member

Background

In #132, we gave Lab libraries the ability to declare dependencies under UWP, WinAppSdk and Uno under both WinUI 2 and 3.

The problem

However, we didn't provide a way for sample projects to declare dependencies the same way. This means that if a sample project needs a nuget package that uses WinUI, they would need to add it to their lab source project, even if that project never used it, or in the case of netstandard projects, can't use it.

The solution

Allow sample projects to include WinUI 2/3 dependencies in the same way as #132 did for library projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev loop ➰ For issues that impact the core dev-loop of building experiments enhancement Improvement to an existing feature templating
Projects
None yet
2 participants