Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scm information and project URL in the pom.xml file #6

Closed
MGaetan89 opened this issue Jun 4, 2024 · 3 comments
Closed

Update scm information and project URL in the pom.xml file #6

MGaetan89 opened this issue Jun 4, 2024 · 3 comments

Comments

@MGaetan89
Copy link

MGaetan89 commented Jun 4, 2024

Context

On Maven Central, we can see that the pom.xml file for ServerSide points to the old repository:

<scm>
  <connection>scm:git:github.com/TagCommander/Android.git</connection>
  <developerConnection>scm:git:ssh://github.com/TagCommander/Android.git</developerConnection>
  <url>https://github.com/TagCommander/android/tree/main</url>
</scm>

Same for the project URL:

<url>https://github.com/TagCommander/android/</url>

Note

This is probably also true for the other modules.

Issue

This causes automatic tools, like Dependabot, to link update PRs to the wrong repository. Also, the lack of tags prevents it from including release notes in the PR description.
For example, you can check this PR.

Proposed solution

@MGaetan89
Copy link
Author

MGaetan89 commented Jun 28, 2024

I see that the newest version of ServerSide and FirebaseDestination use the new repository URL. I guess that the other artefacts will be updated in the same way with their next release?

@ahakimsaid
Copy link
Collaborator

hi @MGaetan89,
yes, indeed, other artifacts will be updated in their next releases

@MGaetan89
Copy link
Author

Thanks, I'm closing this issue then 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants