From d5034d54234700563f14015a9021c3ec69a78d95 Mon Sep 17 00:00:00 2001 From: William Wang Date: Wed, 17 Jan 2024 14:10:38 -0500 Subject: [PATCH] [nix] Update dev-shell.nix with comment on SystemConfiguration Summary: The reqwest requires the SystemConfiguration which is not available in the MacOS linker. This adds a reminder comment to our nix shell to remove the SystemConfiguration dependency when the reqwest issue is resolved: https://github.com/seanmonstar/reqwest/issues/2006#issue-1952682498 Test Plan: Successfully ran `nix develop` Reviewers: ashoat, varun, O1 Nix Subscribers: tomek Differential Revision: https://phab.comm.dev/D10668 --- nix/dev-shell.nix | 1 + 1 file changed, 1 insertion(+) diff --git a/nix/dev-shell.nix b/nix/dev-shell.nix index 29cd113e66..2c05430def 100644 --- a/nix/dev-shell.nix +++ b/nix/dev-shell.nix @@ -111,6 +111,7 @@ mkShell { CoreFoundation CoreServices Security + # required until https://github.com/seanmonstar/reqwest/issues/2006 is resolved SystemConfiguration libiconv # identity service ]);