-
Notifications
You must be signed in to change notification settings - Fork 29
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[keyserver] Fix rust-node-addon after deprecation of --experimental-s…
…pecifier-resolution=node Summary: Context in [ENG-3059](https://linear.app/comm/issue/ENG-3059/keyserver-fails-to-load-napi-compiled-module). `rust-node-addon` was broken by D6695, but `--experimental-specifier-resolution=node` is going away so we need another solution. I got this solution from [this GitHub comment](nodejs/node#40541 (comment)). Depends on D6783 Test Plan: Confirm I could import `rust-node-addon` and call methods on it from @jon's `jonringer/identity-deleteuserrpc` branch Reviewers: jon, varun, max Reviewed By: jon Subscribers: tomek, atul, jon Differential Revision: https://phab.comm.dev/D6784
- Loading branch information
Showing
2 changed files
with
15 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters