From 9a2e0521ac4d5fd38a621162a5215c5ba03ae390 Mon Sep 17 00:00:00 2001 From: telamonian Date: Thu, 29 Aug 2024 23:52:37 -0400 Subject: [PATCH] revert tar security fix, since `tarfile.data_filter` is busted in many python versions - see: https://github.com/python/cpython/issues/107845 --- comfy_cli/utils.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/comfy_cli/utils.py b/comfy_cli/utils.py index 06dc022..cbd024f 100644 --- a/comfy_cli/utils.py +++ b/comfy_cli/utils.py @@ -173,7 +173,9 @@ def _filter(tinfo: tarfile.TarInfo, _path: PathLike): barProg.advance(barTask, _size) _size = tinfo.size - return tarfile.data_filter(tinfo, _path) + # TODO: ideally we'd use data_filter here, but it's busted: https://github.com/python/cpython/issues/107845 + # return tarfile.data_filter(tinfo, _path) + return tinfo else: _filter = None @@ -215,13 +217,13 @@ def create_tarball( _size = 0 - def _filter(tinfo: tarfile.TarInfo, _path: PathLike): + def _filter(tinfo: tarfile.TarInfo): nonlocal _size pathProg.update(pathTask, description=tinfo.path) barProg.advance(barTask, _size) _size = Path(tinfo.path).stat().st_size - return tarfile.data_filter(tinfo, _path) + return tinfo else: _filter = None