Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a picked IP address (rather than a hostname) for the websocket URLs #112

Open
cmadamsgit opened this issue May 22, 2018 · 0 comments

Comments

@cmadamsgit
Copy link

I was trying to run this in a Docker container, but got ws:// URLs with the container's internal IP address. It looks like the code walks over the server's available IP addresses and uses the last one it finds for all ws:// URLs. This won't work in a Docker, but also won't necessarily work right on any server with more than one IP address.

It seems like it would be better to have a configurable hostname to use, or default to the Host: header from the HTTP request (since that got the client here to begin with). The Host: header would work for most hosts (which only have a single A/AAAA record), and a configurable hostname would handle the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant