Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssl_verification=false is not respected in wopiAccessCheck #11162

Open
juliusknorr opened this issue Feb 13, 2025 · 2 comments · May be fixed by #11190
Open

ssl_verification=false is not respected in wopiAccessCheck #11162

juliusknorr opened this issue Feb 13, 2025 · 2 comments · May be fixed by #11190
Assignees
@meven
Labels
24.04 smoke bug

Comments

@juliusknorr
Copy link
Member

Describe the Bug

When making a request to the wopiAccessCheck endpoint while having ssl_verification disabled in coolwsd.xml i still get a CertificateValidation response.

This would block setting up an instance (mostly for development purposes with using this access check in Nextcloud

Steps to Reproduce

  1. Disable ssl verification in coolwsd.xml
  2. Send a request to the wopiAccessCheck that uses a callbackUrl with self-signed certificates that are not in the system trust store

Expected Behavior

I should get an Ok response as the verification is disabled

Actual Behavior

I see a CertificateValidation error

cc @meven
@juliusknorr juliusknorr mentioned this issue Feb 13, 2025
Open
@meven meven removed the unconfirmed label Feb 14, 2025
@meven
Copy link
Contributor

meven commented Feb 14, 2025

Could you share some of the Collabora Online logs, and the section around "Wopi Access Check request callbackUrlStr" and "Result ssl:", with trace or debug log level.
The file is in /tmp/coolwsd.log usually.

@meven meven self-assigned this Feb 17, 2025
@meven
Copy link
Contributor

meven commented Feb 17, 2025

Took me some times to properly reproduce, but now I do.

@meven meven linked a pull request Feb 18, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meven meven

Labels
24.04 smoke bug
Projects
Collabora Online
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wsd/wopiAccessCheck: handle self-signed certificate meven/cool-online
2 participants
@meven @juliusknorr