Skip to content
This repository has been archived by the owner on May 3, 2019. It is now read-only.

Use system qxtglobalshortcut library if available #151

Closed
martinkg opened this issue Nov 4, 2017 · 2 comments
Closed

Use system qxtglobalshortcut library if available #151

martinkg opened this issue Nov 4, 2017 · 2 comments
Assignees
Milestone

Comments

@martinkg
Copy link

martinkg commented Nov 4, 2017

Hi,

on Fedora there is the package qxtglobalshortcut [1] avaiable, so it would be possible to use this instead of the version from the 3rdparty directory. The package will be available at the end of the next week in the stable repos.

# pkgconf --libs qxtglobalshortcut
-lqxtglobalshortcut -lQt5Widgets -lQt5Gui -lQt5Core

# pkgconf --cflags qxtglobalshortcut
-I/usr/include/qxtglobalshortcut -I/usr/include/qt5/QtWidgets -I/usr/include/qt5 -I/usr/include/qt5/QtCore -I/usr/include/qt5/QtGui

can you add a code that check if a qxtglobalshortcut is available as a system library ?

[1] https://koji.fedoraproject.org/koji/packageinfo?packageID=25505

@ColinDuquesnoy
Copy link
Owner

ColinDuquesnoy commented Nov 4, 2017

Good to know. I'll add the check. Does the package come with cmake find_package support or only pkgconfig?

@ColinDuquesnoy ColinDuquesnoy added this to the 3.2.0 milestone Nov 4, 2017
@ColinDuquesnoy ColinDuquesnoy self-assigned this Nov 4, 2017
@martinkg
Copy link
Author

martinkg commented Nov 4, 2017

a first check with 'grep -r find_package *' in the sources gives this back

example/CMakeLists.txt:find_package(qxtglobalshortcut REQUIRED)

@ColinDuquesnoy ColinDuquesnoy changed the title qxtglobalshortcut system library on fedora available Use system qxtglobalshortcut library if available Nov 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants