-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make some dependency changes, support Python 3.10 and 3.11 #5611
Conversation
9beecbd
to
33cdb36
Compare
c2f69e9
to
8874238
Compare
I'm using a fork for testing some things that includes this PR, and I received this error with a brand new Python 3.10 install (installed through Brew) with a brand new venv. This is also a new Red install inside that venv. I had existing instances already configured on this device with alternate python installs and alternate venvs.
I copied my config.json from the Application Support directory to the Preferences directory and I was able to use redbot-setup. |
@aikaterna thanks for testing! This should be resolved now. |
I encountered the same issue on another Mac that had a Python 3.9 venv, while running
|
Getting this traceback in my console whenever I get a CommandNotFound when I try this PR out:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't run bumpdeps for the extras but I assume some of them are out of date already.
…ors#5611) Co-authored-by: jack1142 <[email protected]>
…ors#5611) Co-authored-by: jack1142 <[email protected]>
…ors#5611) Co-authored-by: jack1142 <[email protected]>
Description of the changes
This PR makes a bunch of dependency changes (not just updates) and enables support for Python 3.10.
Added primary dependencies:
typing_extensions
(we don't use it but we probably will in the future)yarl
(we use it in our code so it shouldn't be transitive)aiodns
,Brotli
,orjson
(some of the speedup dependencies foraiohttp
anddiscord.py
)Replaced dependencies:
apsw-wheels
withapsw
appdirs
replaced byplatformdirs
Not that I don't go through changelogs of all our dependencies but I'm not a fan of this.
chardet
replaced bycharset-normalizer
(transitive dependency ofaiohttp
)fuzzywuzzy
replaced byrapidfuzz
Removed dependencies:
aiosqlite
(this library is not used by Red anymore)PyNaCl
(transitive dependency ofdiscord.py[voice]
which we don't actually use)python-Levenshtein-wheels
(transitive dependency offuzzywuzzy
which we replaced withrapidfuzz
)The PyNaCl removal is still up for consideration, I'm not entirely sure why we have it added if we're using LL rather than d.py's own voice functionality.
Test run of updated install instructions:
Have the changes in this PR been tested?
Yes