Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 Core] Setup should warn if replacing existing instance. #1265

Closed
1 of 2 tasks
Aioxas opened this issue Jan 20, 2018 · 1 comment · Fixed by #1469
Closed
1 of 2 tasks

[V3 Core] Setup should warn if replacing existing instance. #1265

Aioxas opened this issue Jan 20, 2018 · 1 comment · Fixed by #1469
Assignees
Labels
Type: Enhancement Something meant to enhance existing Red features.

Comments

@Aioxas
Copy link
Member

Aioxas commented Jan 20, 2018

Please be sure to read through other issues as well to make sure what you are suggesting/reporting has not already
been suggested/reported

Type:

  • Suggestion
  • Bug

Brief description of the problem

Running redbot-setup with an existing redbot instance doesn't trigger any warnings, it just replaces it.

Expected behavior

Warnings before anything is done and options to cancel or continuing.

Actual behavior

Nothing, it continues as it is and replaces the existing instance values with the new instance values (same name)

Steps to reproduce

  1. Run redbot-setup
  2. follow the instructions on creating a new instance.
  3. Make a new instance
  4. Check config.json or the flags for details on the instances...is there even one?
  5. Repeat Steps 2-4 for another instance and check.
@Aioxas Aioxas changed the title [V3 Core] Replaced existing instances during redbot-setup [V3 Core] redbot-setup replaces existing instances Jan 20, 2018
@Kowlin Kowlin added Type: Enhancement Something meant to enhance existing Red features. V3 labels Jan 21, 2018
@Kowlin Kowlin changed the title [V3 Core] redbot-setup replaces existing instances [V3 Core] Setup should warn if replacing existing instance. Jan 21, 2018
@palmtree5 palmtree5 self-assigned this Mar 13, 2018
@tekulvw
Copy link
Member

tekulvw commented Mar 28, 2018

Fixed with #1469

@tekulvw tekulvw closed this as completed Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants