Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Move job logic out of Backend\Base class #39

Open
adamwight opened this issue Mar 27, 2015 · 1 comment
Open

Feature request: Move job logic out of Backend\Base class #39

adamwight opened this issue Mar 27, 2015 · 1 comment

Comments

@adamwight
Copy link
Contributor

I like the idea of keeping before & after hooks on every action in the Base class, but what do you think about decoupling the job tracking (last_job_id and open_items) into a new class? Or even isolating all job queue logic in a new component? Plain old queue stuff is a useful service to provide in a library, on its own!

Also, I don't understand how the before and after hooks would be overridden. Maybe there should be an example in the demo/ dir? I ask because I'm thinking about removing or refactoring these functions, if they aren't being used.

@adamwight
Copy link
Contributor Author

On second thought, maybe last_job_id is still useful for general queue purposes, but could be rolled into Message::$id, and all the get/pop functions will return a Message wrapper around the data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant