Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soft_delete should be model logic, not view logic. #69

Open
stam opened this issue Jul 14, 2017 · 0 comments
Open

Soft_delete should be model logic, not view logic. #69

stam opened this issue Jul 14, 2017 · 0 comments
Labels
Breaking change

Comments

@stam
Copy link
Contributor

stam commented Jul 14, 2017

In BinderModels, model.delete() actually deletes the model instead of just softdeleting it. Soft_delete is hacked in the view.

If a model has a deleted field, model.delete() should softdelete it, unless something like force=True is given.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sjamaan @stam