Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router throws AttributeError when project urls.py follows django 2 style urls. #100

Open
daanvdk opened this issue Aug 23, 2018 · 0 comments
Assignees

Comments

@daanvdk
Copy link
Collaborator

daanvdk commented Aug 23, 2018

In Django 2 you import url functions from django.urls instead of django.conf.urls.
However since binder.router only imports django and then uses django.conf.urls this throws an AttributeError when the url file does not import django.conf.urls itself. This used to always be the case since this is how old projects configured urls which is probably why this slipped through. For now just importing django.conf.urls in the project fixes the issue but probably should be fixed in binder itself.

@stefanmajoor stefanmajoor self-assigned this Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants