Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove proof from settings #101

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tyliec
Copy link
Member

@tyliec tyliec commented May 6, 2024

No description provided.

@tyliec tyliec requested a review from a team as a code owner May 6, 2024 20:42
@tyliec tyliec marked this pull request as draft May 6, 2024 20:42
@russtoku
Copy link
Member

russtoku commented May 7, 2024

This works to remove proof from the user's settings page but proof is still visible in other web pages. A quick look for proof shows that proof is tangled into the other parts of Froide.

froide (main)$ rg -l proof
vite.config.js
frontend/javascript/components/proofupload/proof-form.vue
frontend/javascript/components/proofupload/proof-upload.vue
frontend/javascript/components/makerequest/request-form.vue
frontend/javascript/components/makerequest/request-page.vue
frontend/javascript/proofupload.js

froide/urls.py
froide/settings.py

froide/account/templates/account/settings.html
froide/account/templates/account/settings_base.html

froide/foirequest/templates/foirequest/request.html
froide/foirequest/templates/foirequest/body/actions/send_message.html
froide/foirequest/views/make_request.py
froide/foirequest/views/message.py
froide/foirequest/utils.py
froide/foirequest/forms/message.py
froide/foirequest/services.py

froide/proof/views.py
froide/proof/tests.py
froide/proof/urls.py
froide/proof/forms.py
froide/proof/templates/proof/proof_settings.html
froide/proof/templates/proof/widget.html
froide/proof/widgets.py
froide/proof/templates/proof/proof_message.html
froide/proof/apps.py
froide/proof/templatetags/proofupload.py
froide/proof/migrations/0001_initial.py
froide/proof/models.py

locale/de/LC_MESSAGES/django.po

This begs the larger question of should some parts of the new Froide not be include in UIPA? There are several new things besides proof such as campaign, geo location, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants