Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back navigation and Delete-version button can cause data hazard #430

Open
blerner opened this issue Oct 25, 2022 · 1 comment
Open

Back navigation and Delete-version button can cause data hazard #430

blerner opened this issue Oct 25, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@blerner
Copy link
Contributor

blerner commented Oct 25, 2022

We disable the Delete-version button once students start taking that version of the exam. But if a professor navigates to the proctoring page, say, there's no way back to the exam page other than the browser's Back button...at which point the page restores with a Delete-version button that's still enabled.

We need to rethink page navigation somewhat thoroughly, from a usability perspective, but this is the first instance where I've seen a data hazard. (Fortunately, https://github.com/CodeGrade/hourglass/blob/master/app/graphql/mutations/destroy_exam_version.rb#L37 ensures that the mutation shouldn't allow the version to be destroyed, but that's a risky last line of defense!)

@blerner blerner added the bug Something isn't working label Oct 25, 2022
@blerner
Copy link
Contributor Author

blerner commented Feb 18, 2024

Added a confirmation to all Delete-version buttons in 8a80228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant