Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Compile errors by SwiftLintPlugin #188

Closed
LostInCompilation opened this issue May 14, 2023 · 0 comments · Fixed by CodeEditApp/CodeEditTextView#40
Closed

🐞 Compile errors by SwiftLintPlugin #188

LostInCompilation opened this issue May 14, 2023 · 0 comments · Fixed by CodeEditApp/CodeEditTextView#40
Labels
bug Something isn't working

Comments

@LostInCompilation
Copy link

Description

See CodeEditApp/CodeEdit#1267

When trying to compile the current sources with XCode 14.3 on macOS 13.3.1(a) I get the following compilation error:

.../CodeEditTextView/Tests/CodeEditTextViewTests/CodeEditTextViewTests.swift:4:1 Usage of // swiftlint:disable all is prohibited
.../CodeEditTextView/Tests/CodeEditTextViewTests/STTextViewControllerTests.swift:7:1 Usage of // swiftlint:disable all is prohibited

https://github.com/CodeEditApp/CodeEditTextView/blob/521dd433df903c405e1d7edc4d442ba7933f893c/Tests/CodeEditTextViewTests/CodeEditTextViewTests.swift#L4
https://github.com/CodeEditApp/CodeEditTextView/blob/521dd433df903c405e1d7edc4d442ba7933f893c/Tests/CodeEditTextViewTests/STTextViewControllerTests.swift#L7

The issues are raised by the packages CodeEditLanguages and CodeEditTextView. The cause is the latest update of SwiftLintPlugin from v0.2.2 to v0.2.3. This update updated SwiftLint from v0.50 to v0.51 which introduced stricter rules on blanket disable commands.

Disabling all SwiftLint checks is no longer supported. Only the necessary lint issues should be disabled.

To Reproduce

  1. Download a fresh clone of the CodeEditApp repo
  2. Build

Expected Behavior

No issues

Version Information

CodeEditTextView: 0.6.2
macOS: 13.3.1(a)
Xcode: 14.3

Additional Context

No response

Screenshots

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🏁 Complete
Development

Successfully merging a pull request may close this issue.

1 participant