Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 cmd+delete for deleting terminal become inactive after trying to delete a file with the shortcut #1343

Open
Cubik65536 opened this issue Jun 20, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Cubik65536
Copy link
Contributor

Description

In PR #1329, some improvements on the focus system are added so commands like cmd+delete for deleting current terminal or selected file can be handled more easily. But, after the user selects a file and try to use cmd+delete to delete a file (which will not work because it's not implemented), cmd+delete for deleting the terminal will also stop working.

To Reproduce

  1. Open a project with CodeEdit
  2. Select a terminal tab
  3. Use cmd+delete to delete the terminal (it will work as intended)
  4. Select a file
  5. Use cmd+delete to delete the file (it will not work because it's yet to be implemented)
  6. Select a terminal tab again
  7. Use cmd+delete to delete the terminal (this time it will stop working)

Expected Behavior

The terminal should be deleted.

Version Information

CodeEdit: commit 6f39159
macOS: macOS Sonoma 14.0 Beta (23A5257q)
Xcode: 15.0 beta (15A5160n)

Additional Context

No response

Screenshots

2023-06-18_19-21-31.mp4
@Cubik65536 Cubik65536 added the bug Something isn't working label Jun 20, 2023
@Wouter01 Wouter01 self-assigned this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants