Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nanoid v5 - async API removed #1656

Open
daniser opened this issue Sep 13, 2023 · 1 comment
Open

nanoid v5 - async API removed #1656

daniser opened this issue Sep 13, 2023 · 1 comment
Labels
breaking-changes Introducing new BREAKING CHANGES enhancement New feature or request
Milestone
2.0.0

Comments

@daniser
Copy link
Contributor

daniser commented Sep 13, 2023

Environment

Reproduction

Describe the bug

In the latest version of nanoid, they removed nanoid/async module
https://github.com/ai/nanoid/blob/main/CHANGELOG.md#50
Hence Pinia ORM (master branch as of now) build failing:

src/packages/nanoid/casts/AsyncCast.ts(1,24): error TS2307: Cannot find module 'nanoid/async' or its corresponding type declarations.

I think we should remove it too.

Additional context

No response

Logs

No response
@CodeDredd CodeDredd added enhancement New feature or request and removed pending triage labels Sep 15, 2023
@CodeDredd CodeDredd added this to the 2.0.0 milestone Sep 17, 2023
@CodeDredd CodeDredd added the breaking-changes Introducing new BREAKING CHANGES label Sep 17, 2023
@CodeDredd
Copy link
Owner

CodeDredd commented Sep 17, 2023 •
edited
Loading

Totally aggree with you. Its going to be removed in v2. Now i need to mapke it deprecated to use it. The User can still use v5 already. He just cant use the async uuid method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-changes Introducing new BREAKING CHANGES enhancement New feature or request
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@daniser @CodeDredd